Skip to content

Fenrir: socket fixes, wolfssl macro updates, rsa verify fix and cleanup#583

Merged
padelsbach merged 3 commits into
wolfSSL:masterfrom
stenslae:f-5610-1297-1705-1701
Jul 13, 2026
Merged

Fenrir: socket fixes, wolfssl macro updates, rsa verify fix and cleanup#583
padelsbach merged 3 commits into
wolfSSL:masterfrom
stenslae:f-5610-1297-1705-1701

Conversation

@stenslae

@stenslae stenslae commented Jun 30, 2026

Copy link
Copy Markdown
Member

Applied Fenrir fixes and audited for similar errors:

  • Replaced standard C string library calls with wolfSSL macros.
  • Fixed resource leaks on client accept loop failures.
  • Added missing bounds/error checks and corrected condition flows to continue; on errors.
  • clients & servers: Initialized socket/listen descriptors to -1 (instead of 0 ) to
    closure of stdin ( fd 0 ) during cleanup.
  • Fixed a bug in the RSA non-blocking signature verification check by correctly comparing verifySz against
    inSz.
  • Assigned socket descriptors to SOCKET_INVALID immediately after closing
  • PSK Resume: Added a missing null check on the sslResume pointer

@stenslae stenslae self-assigned this Jun 30, 2026
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jun 30, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #583

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src
Findings: 1

Low (1)

Orphaned exit: label after removing all goto exit statements

File: ESP32/TLS13-wifi_station-server/main/station_example_main.c:1016
Function: tls_smp_server_task
Category: Dead/unreachable code

The PR deleted both goto exit; statements in the accept loop, but the exit: label remains. It is now referenced by nothing, producing an unused-label warning (compile failure under -Werror).

Recommendation: Remove the now-unreferenced exit: label.

Referenced code: ESP32/TLS13-wifi_station-server/main/station_example_main.c:1016-1017 (2 lines)

This review was generated automatically by Fenrir. Findings are non-blocking.

@stenslae
stenslae force-pushed the f-5610-1297-1705-1701 branch from d4e4291 to 2ee988c Compare June 30, 2026 17:51
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jun 30, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #583

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

No new issues found in the changed files. ✅

@stenslae stenslae assigned wolfSSL-Bot and unassigned wolfSSL-Bot Jun 30, 2026
@stenslae
stenslae force-pushed the f-5610-1297-1705-1701 branch from 2ee988c to f4d4399 Compare June 30, 2026 23:06
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jun 30, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #583

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

No new issues found in the changed files. ✅

@stenslae stenslae changed the title F-5610 F-1701 F-1297 wolfssl macro updates, rsa verify fix and cleanup Fenrir: socket fixes, wolfssl macro updates, rsa verify fix and cleanup Jul 1, 2026
@stenslae
stenslae force-pushed the f-5610-1297-1705-1701 branch from f4d4399 to f774adb Compare July 1, 2026 18:09
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 1, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #583

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

No new issues found in the changed files. ✅

F-5610: fix ENC28J60 TLS server continuing past a NULL WOLFSSL sessio…
780342b 
…n, and harden ESP32 socket/string handling
@stenslae stenslae removed their assignment Jul 7, 2026
@padelsbach padelsbach assigned padelsbach and unassigned wolfSSL-Bot Jul 10, 2026
padelsbach
padelsbach requested changes Jul 10, 2026
View reviewed changes

@padelsbach padelsbach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor touch ups requested

Comment thread dtls/client-dtls13-cid.c Outdated
Comment thread dtls/client-dtls.c Outdated
Comment thread dtls/server-dtls.c
@padelsbach padelsbach assigned stenslae and unassigned padelsbach Jul 10, 2026
F-1701 F-1292 F-3225 F-3902 F-1705: fix double-close, wrong-socket, a…
3a34131 
…nd NULL-check bugs, and harden fd/session sentinel handling across DTLS, TLS, PSK, and CAN-bus examples
@stenslae
stenslae force-pushed the f-5610-1297-1705-1701 branch from f774adb to 6546aee Compare July 13, 2026 18:34
@stenslae stenslae assigned padelsbach and unassigned stenslae Jul 13, 2026
padelsbach
padelsbach requested changes Jul 13, 2026
View reviewed changes

@padelsbach padelsbach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just couple more findings

Comment thread dtls/memory-bio-dtls.c Outdated
Comment thread dtls/server-dtls.c Outdated
@stenslae
stenslae force-pushed the f-5610-1297-1705-1701 branch from 6546aee to ae92d31 Compare July 13, 2026 22:03
padelsbach
padelsbach approved these changes Jul 13, 2026
View reviewed changes

@padelsbach padelsbach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@padelsbach
padelsbach merged commit 9ac1bcb into wolfSSL:master Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@padelsbach padelsbach padelsbach approved these changes
@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot Awaiting requested review from wolfSSL-Fenrir-bot

Assignees

@padelsbach padelsbach

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stenslae @padelsbach @wolfSSL-Fenrir-bot @wolfSSL-Bot